If you smoker, your a smoker. If you don't, your not. Pretty simple.
Your a nicotine user, and a vaper, not a smoker.
If he's putting "smoker" on your medical records, instead of nicotine user, or vaper, that is misleading the facts, which could be important one day. You don't want that like of confusion or laziness on your medical records.
My doctor is happy with me having given up smoking. She doesnt think of me as a smoker medically, but merely a nicotine user. She is happy to dialogue about things, and when she knows her stuff I listen, and when i know something she listens to me.
Its called mutual respect. I expect nothing less from any doctor, that I ever have, and if I dont like their attitude, of find them arrogant, or there skills wanting, I go somewhere else.
There are always good doctors, and theres plenty of bad ones too. The golden thing is finding one that is not arrogant, listens and is an experienced and talented diagnostician. I have one of those in both towns I stay in.
Its like having a good hairdresser, or a good lawyer, or a good counseller. Anything less than the right fit, just isnt worth doing - and medicine is more important than a good haircut too.