Hard question. They can both be done well and done badly.
Slide fill is easier, but has issues. It is prone to get loose which makes it easier for it to either leak or break. Screw on is stronger and generally won’t leak, but can be cross threaded (the solomon2 has very thin threads and was prone to this)
A bad screw on is better than a bad slide. A Bad screw on you can work with, but bad slide caps will fail catastrophically and do things like ruin clothing and destroy the
device.
A good slide is better than a good screw on but harder to do, and rarer. So rare poor schmucks who bought bad
smok stuff are so put off by slides they won’t
buy em.
A tethered bayonet fitting was the traditional work around for this. You see it in older military stuff a lot.
It sort of splits the difference. Easier and faster than a screw on, but more rugged than a slide. If they’re done right you can also use em one handed which is the primary advantage of a slide. They may be more expensive than both. You don’t see them much any more.