if anything i'd say
vaping has improved my range, etc. (not that i'm great but...) analogs/smoking
definitely impacts your voice negatively. dry "pipes" is never a good thing vocally (even without analogs
or vaping) so stay hydrated and belt 'em out as best you can.